Test on more platforms, enforce code quality, code cleanup #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoh
force-pushed
the
hoh-code-cleanup-2
branch
from
1d3be30
to
f135870
Compare
hoh
force-pushed
the
hoh-code-cleanup-2
branch
3 times, most recently
from
a109638
to
7668ccb
Compare
hoh
force-pushed
the
hoh-code-cleanup-2
branch
from
3f7504e
to
b4e3507
Compare
Merged
odesenfans
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves code quality checks in their own workflow, adds
isortandflake8checks.Tests now run on the following Docker images:
There is duplication between the dockerfile files, I am not sure how to cleanly deduplicate that.
Pythom 3.11 is not compatible yet, see issue #4 .