Feature: download on ipfs client #36

1yam · 2023-07-10T15:13:02Z

Solutions:

Add a function called download_file_ipfs that downloads from ipfs.io/ipfs/.
Refactor the current download process to include:
- Chunk size and storage into a buffer (BytesIO). (memory friendly)
Add a test for the download functionality.

src/aleph/sdk/client.py

tests/unit/test_download.py

Co-authored-by: Hugo Herter <git@hugoherter.com>

Co-authored-by: Olivier Desenfans <desenfans.olivier@gmail.com>

…rebased' into 1yam-download_ipfs-rebased

src/aleph/sdk/client.py

src/aleph/sdk/exceptions.py

src/aleph/sdk/client.py

Feature: download on ipfs client

197899a

hoh reviewed Jul 10, 2023

View reviewed changes

src/aleph/sdk/client.py Outdated Show resolved Hide resolved

src/aleph/sdk/client.py Outdated Show resolved Hide resolved

src/aleph/sdk/client.py Outdated Show resolved Hide resolved

src/aleph/sdk/client.py Show resolved Hide resolved

odesenfans requested changes Jul 10, 2023

View reviewed changes

1yam and others added 2 commits July 10, 2023 17:58

Update src/aleph/sdk/client.py

6ab843b

Co-authored-by: Hugo Herter <git@hugoherter.com>

Update src/aleph/sdk/client.py

993b12a

Co-authored-by: Hugo Herter <git@hugoherter.com>

hoh mentioned this pull request Jul 10, 2023

Downloads should use files on disk instead of bytes in RAM #37

Closed

1yam and others added 6 commits July 10, 2023 18:06

Update src/aleph/sdk/client.py

ac5d869

Co-authored-by: Olivier Desenfans <desenfans.olivier@gmail.com>

Fix: Pr change

2898e52

Merge remote-tracking branch 'refs/remotes/origin/1yam-download_ipfs-…

cea3efb

…rebased' into 1yam-download_ipfs-rebased

Fix: Handle IPFS downloads in download_file_to_buffer.

f9b76bc

Fix: Useless code

b30cf00

Fix: Handle IPFS downloads in download_file_to_buffer when return 413.

067c63b

1yam requested a review from odesenfans July 11, 2023 12:22

odesenfans requested changes Jul 11, 2023

View reviewed changes

1yam added 3 commits July 11, 2023 16:23

Fix: Remove chunk_size from paramater

d180dba

Refactor: download ipfs & aleph on same function

cb8c271

Fix: Error Handling

5a066dc

odesenfans requested changes Jul 12, 2023

View reviewed changes

src/aleph/sdk/client.py Outdated Show resolved Hide resolved

src/aleph/sdk/client.py Outdated Show resolved Hide resolved

src/aleph/sdk/exceptions.py Show resolved Hide resolved

Refactor: Encapsulate read and write of the download (ipfs & aleph)

1004c8c

odesenfans requested changes Jul 12, 2023

View reviewed changes

1yam added 2 commits July 12, 2023 14:27

Fix: cleaning the code

254379a

Fix: variable name

c3d18a6

odesenfans previously approved these changes Jul 12, 2023

View reviewed changes

Merge branch 'main' into 1yam-download_ipfs-rebased

b3e9f1d

1yam dismissed odesenfans’s stale review via b3e9f1d July 12, 2023 13:32

Feature: Download on ipfs client

7d4b2ba

odesenfans approved these changes Jul 12, 2023

View reviewed changes

odesenfans merged commit 66a53af into aleph-im:main Jul 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: download on ipfs client #36

Feature: download on ipfs client #36

1yam commented Jul 10, 2023

Feature: download on ipfs client #36

Feature: download on ipfs client #36

Conversation

1yam commented Jul 10, 2023