Fix: ETH verify_signature fails on checksummed addresses #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: As Ethereum addresses may contain checksum information in capitalizing their letters, comparing the input address and the resulting public_key of the signature verification process resulted in false negatives.
Solution: Casefold both the address and public key before comparing them. Added further tests to both ETH and SOL accounts to increase coverage and test for other unforeseen errors.