Skip to content

Conversation

@1yam
Copy link
Member

@1yam 1yam commented Jan 6, 2026

In pyaleph we can use the endpoints:

/api/v0/price/estimate

To fetch price of Executable Content, but we can also use it for store Content, but wasn't handle here

@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Jan 6, 2026
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Summary:
The PR introduces a new method get_store_estimated_price which adds significant complexity to the existing codebase. This method involves multiple steps and interactions with external APIs, which could potentially introduce bugs or require a deep understanding of the project's architecture. The method is substantial and does not seem to be a simple refactoring or documentation update.

Highlighting relevant parts of the diff:

  • Addition of a new method get_store_estimated_price with extensive logic.
  • Involvement of external API calls and JSON serialization.
  • Potential for introducing bugs or requiring complex debugging.

This PR likely requires a thorough review by experienced developers who understand the intricacies of the project's architecture and the potential risks involved.

@1yam 1yam force-pushed the 1yam-better-filter-crn branch from 8c17a59 to 2a5daff Compare January 6, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLACK This PR has critical implications and must be reviewed by a senior engineer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants