Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-SOL fixes #178

Merged
merged 7 commits into from
Oct 11, 2024
Merged

Post-SOL fixes #178

merged 7 commits into from
Oct 11, 2024

Conversation

philogicae
Copy link
Member

No description provided.

@philogicae philogicae self-assigned this Oct 9, 2024
nesitor
nesitor previously approved these changes Oct 11, 2024
Copy link
Member

@nesitor nesitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@philogicae philogicae marked this pull request as ready for review October 11, 2024 10:38
@github-actions github-actions bot added the BLUE This PR is simple and straightforward. label Oct 11, 2024
Copy link

"summary": "Minor changes and refactoring",
"explanation": "The provided diff includes minor changes and refactoring in the codebase. The changes are limited to updating the order of items in a dictionary and reorganizing the method definitions for consistency. There are no significant modifications to the logic or functionality of the code. These changes are unlikely to introduce bugs and are generally considered safe for review.",
"highlight": [
{
"line": 21,
"text": "Chain.AVAX: ETHAccount,"
},
{
"line": 23,
"text": "Chain.SOL: SOLAccount,"
},
{
"line": 43,
"text": "private_key_path and private_key_path.is_file()"
},
{
"line": 45,
"text": "private_key_str and private_key_str"
},
{
"line": 61,
"text": "Chain.SOL if isinstance(account, SOLAccount) else Chain.ETH"
}
]
}

@nesitor nesitor merged commit d54e9ac into main Oct 11, 2024
13 checks passed
@nesitor nesitor deleted the post-sol-fixes branch October 11, 2024 17:01
Antonyjin pushed a commit that referenced this pull request Oct 15, 2024
* Missing chain field on auth

* Fix Signature of Solana operation for CRN

* Add export_private_key func for accounts

* Improve _load_account

* Add chain arg to _load_account

* Increase default HTTP_REQUEST_TIMEOUT

* Typing

---------

Co-authored-by: Olivier Le Thanh Duong <olivier@lethanh.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLUE This PR is simple and straightforward.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants