Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix settings #162

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Fix settings #162

merged 2 commits into from
Sep 3, 2024

Conversation

philogicae
Copy link
Member

No description provided.

@github-actions github-actions bot added the BLUE This PR is simple and straightforward. label Aug 29, 2024
Copy link

"summary": "This PR introduces changes to the configuration and environment setup of the Aleph.im SDK. The changes include updates to the .env.example, .gitignore, and src/aleph/sdk/conf.py files. Additionally, there are updates to the settings and environment variables for the SDK. The changes are focused on improving the configuration and environment setup, which are likely to be minor modifications that do not introduce significant risks.",
"highlight": [
"new file mode 100644 a/.env.example",
"new file mode 100644 a/.gitignore",
"index 38afc381..fc7f9d6b 100644 a/src/aleph/sdk/conf.py",
"DEFAULT_CONFIDENTIAL_FIRMWARE",
"DEFAULT_CONFIDENTIAL_FIRMWARE_HASH",
"DEFAULT_ROOTFS_SIZE",
"DEFAULT_INSTANCE_MEMORY",
"DEFAULT_HYPERVISOR",
"VM_URL_PATH",
"VM_URL_HOST",
"CHAINS_ENV",
"settings.delattr(f"CHAINS_{fields}")"
]
}

1yam
1yam previously approved these changes Aug 30, 2024
Copy link
Collaborator

@1yam 1yam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/aleph/sdk/conf.py Outdated Show resolved Hide resolved
@hoh hoh merged commit 1bc6a4f into main Sep 3, 2024
13 checks passed
@philogicae philogicae deleted the fix-settings branch September 3, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLUE This PR is simple and straightforward.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants