-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix optional trusted_exec #158
Conversation
The changes made are primarily focused on refactoring the code to improve readability and maintainability. There are no substantial modifications to the logic, and the addition of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't change anything, if you pass trusted_execution=None or just don't pass it to InstanceEnvironment
You can test it by yourself by creating an InsatanceContent and using the method .dict(exclude_none=True)
Normally that bug with the trusted_execution was already fixed and the client already didn't send the trusted_execution field |
In that client commit aleph-im/aleph-client@9eba48d |
Canceled |
Problem: when creating non-coco instances, trusted_execution field is populated
Solution: To not include it
Note: CCN will still put "trusted_execution": null in the final processed message.