Fix: Could not generate signed messages outside HTTP client #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Developers could not generate signed messages without using the AlephHttpClient. Solution: Move and rename the method on the abstract class; Move the utility that generates sha256 hashes to utils.py.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
=======================================
Coverage 84.17% 84.17%
=======================================
Files 27 27
Lines 1131 1131
Branches 188 188
=======================================
Hits 952 952
Misses 176 176
Partials 3 3 ☔ View full report in Codecov by Sentry. |
|
Failed to retrieve llama text: POST 504: 504 Gateway Time-outThe server didn't respond in time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Developers could not generate signed messages without using the AlephHttpClient.
Solution: Move and rename the method on the abstract class; Move the utility that generates sha256 hashes to utils.py.