Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: No notification when dependency update breaks #119

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

hoh
Copy link
Member

@hoh hoh commented Apr 23, 2024

Problem: Since the SDK is a library, it should not enforce the
version of the libraries it requires too strictly.

This causes issues when an incompatible dependency upgrade
breaks compatibility without anyone noticing except for the next
CI build.

Solution: Run tests daily with the latest dependencies.

Problem: Since the SDK is a library, it should not enforce the
version of the libraries it requires too strictly.

This causes issues when an incompatible dependency upgrade
breaks compatibility without anyone noticing except for the next
CI build.

Solution: Run tests daily with the latest dependencies.
@github-actions github-actions bot added the RED This PR is complex and may require more time to review. label Apr 23, 2024
Copy link

The workflow is scheduled to run every day at 04:00 UTC, which could potentially affect the reliability of the library if not properly managed. This is a moderate risk as it involves a scheduled task that runs at a specific time.

The PR includes changes to the .github/workflows directory, which is a configuration directory for GitHub Actions. GitHub Actions are used to automate, customize, and execute software development workflows.

Please note that this PR is categorized as RED as it includes changes that could potentially break the functionality of the library if not properly managed. This PR also includes a new scheduled workflow, which could potentially disrupt the existing functionality of the library.

Here's a summary of the changes:

  • Added a new scheduled workflow to the .github/workflows directory.
  • The scheduled workflow runs daily at 04:00 UTC to check for updates in unfrozen dependencies.
diff --git a/.github/workflows/pytest.yml b/.github/workflows/pytest.yml
index 69382cc..89c3dab 100644
--- a/.github/workflows/pytest.yml
+++ b/.github/workflows/pytest.yml
@@ -7,6 +7,11 @@ on:
   pull_request:
     branches:
        - main
+  schedule:
+     # Run every night at 04:00 (GitHub Actions timezone) 
+     # in order to catch when unfrozen dependency updates
+     # break the use of the library.
+     - cron: '4 0 * * *'
 
 jobs:
   build:

Please review this PR carefully and consider the potential impact on the library's functionality.

@hoh hoh requested a review from MHHukiewitz April 25, 2024 13:14
@MHHukiewitz MHHukiewitz merged commit 28ada83 into main Apr 29, 2024
26 checks passed
@MHHukiewitz MHHukiewitz deleted the hoh-cron-run branch April 29, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RED This PR is complex and may require more time to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants