-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dump_content
function to avoid unclear item_content
transformation process
#90
base: main
Are you sure you want to change the base?
Conversation
Can you explain the issue in more details ? I do not understand what the problem is from this short description. |
Well, I figured that some functions in connection with messages are too important, to have them spread out around the different repos. IMHO we want:
This way we can also write tests for the validators, to make sure that what transformations we implemented here, are working fine with the current message spec. |
This branch is mixing unrelated stuff, can you move |
…fault method to dump message content
f7cc2fb
to
3febd8e
Compare
Is the code coverage increasing or at least identical after these changes ? I don't see changes in the tests. |
93% -> 92%, due to the decreasing coverage on the |
56b4568
to
9bd0cc6
Compare
In order to avoid mistakes when creating the
item_content
of a message, theextended_json_encoder
has been added from thealeph-sdk-python
package to this central piece of the aleph architecture.Based on #89