Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add payment field to BaseExecutableContent with specifics for payment type #82

Merged
merged 6 commits into from
Jan 2, 2024

Conversation

MHHukiewitz
Copy link
Member

In preparation for the Superfluid pay-as-you-go option for Programs/Instances.

@MHHukiewitz MHHukiewitz requested a review from hoh December 5, 2023 15:00
@MHHukiewitz MHHukiewitz marked this pull request as ready for review December 5, 2023 15:06
@hoh hoh marked this pull request as draft December 6, 2023 15:48
@hoh
Copy link
Member

hoh commented Dec 6, 2023

Thanks for starting this. I converted it to draft since we'll need to run some experiments and validate the metadata we want to attach.

@hoh
Copy link
Member

hoh commented Dec 7, 2023

The chain used for payment should be the same as the chain of the sender and the receiver.
The chain field of the BaseMessage class is not signed however 🤔

@MHHukiewitz
Copy link
Member Author

The chain field of the BaseMessage class is not signed however 🤔

Maybe we need to start thinking about a "version" field in the highest layer of the message, so we can finally introduce breaking changes, without invalidating prior signatures of messages?

@MHHukiewitz MHHukiewitz marked this pull request as ready for review December 15, 2023 08:59
aleph_message/models/execution/base.py Outdated Show resolved Hide resolved
aleph_message/models/execution/base.py Outdated Show resolved Hide resolved
@hoh
Copy link
Member

hoh commented Dec 15, 2023

Related to aleph-im/aleph-vm#512

@MHHukiewitz MHHukiewitz merged commit 1f5e910 into main Jan 2, 2024
2 checks passed
@MHHukiewitz MHHukiewitz deleted the mhh-pay-as-you-go-v1 branch January 2, 2024 13:13
@MHHukiewitz MHHukiewitz restored the mhh-pay-as-you-go-v1 branch January 4, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants