Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated liminial_diffusion_v1 and liminal_diffusion_source models #133

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

0xphk
Copy link

@0xphk 0xphk commented Jul 20, 2022

Hi,

I added the two liminal_diffusion models from BrainArtLabs. Their collab link was shared on reddit, so I tried to integrate them.
(https://colab.research.google.com/drive/1pHBrk8FsSmvu_TZREhZpK4jwmRBLebS_)

Models are: liminal_diffusion_v1 and liminal_diffusion_source

I've tested both models, but only on my local instance running on a 2070 with already downloaded models.
Links and checksums are included, so download should work, but I couldn't test this here.

I really like this project and would love to contribute to it.
As this is my second PR ever, please bear with me if I've done something wrong.

best wishes

@aletts
Copy link
Collaborator

aletts commented Jul 21, 2022

Thanks for the PR! It looks all good, and that it'll work. I'll see about picking the version number, etc.

@0xphk
Copy link
Author

0xphk commented Jul 22, 2022

Do you have an advice for integrating additional models? I've tested and integrated the two new KaliYuga-Ai models "lithographic" and "medieval" to a local repository. Should I create a new branch in the fork based on main (without liminal) or based on my changes in this branch? Or do I have to merge this one with main first and create a new branch from this? I'm not very familiar with branches and PR's so sorry for the beginner questions.

@0xphk
Copy link
Author

0xphk commented Jul 29, 2022

I fixed the model settings for use in colab, somehow it worked locally but not in colab, now both work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants