Java8 baseline & bump all dependencies #389
Conversation
|
some tests still failing as the command-line behaviour between plexus-utils 1.X and 3.X changed one instance is that empty args passed to a cmd are treated differently |
move to java8 & bump dependencies where applicable and/or were not pulled up due to java7 support latest maven 3.9.0 in wrapper to proof plugin is compatible with it (as shown via the integration-tests) implements #369
…r java7 compatibility
\"\" would become litellarlly \"\" in Ubuntu, but an empty value on windows my guess: encoding of ', ", \" changed across OSes in newer plexus-utils versions
| @@ -546,7 +549,12 @@ protected void initGitFlowConfig() throws MojoFailureException, CommandLineExcep | |||
| */ | |||
| private void gitSetConfig(final String name, String value) throws MojoFailureException, CommandLineException { | |||
| if (value == null || value.isEmpty()) { | |||
| value = "\"\""; | |||
There was a problem hiding this comment.
before, there would be actually \"\" (with escape chars!) in the .gitconfig file. Only on Ubuntu, but not Windows.
…Unknown lifecycle phase "". You must specify a valid lifecycle phase or a goal ...", was fine in plexus-utils 1.X or for git, Failed cmd ['git'] with args [[merge, --no-ff, , release/0.0.3, , ]], bad exit code [1]. Out: [merge: - not something we can merge my guess: handling of empty args changes between plexus-utils major versions
DRoppelt
changed the title
|
@DRoppelt Thank you! |
|
:) Just wondering, do you plan to release it soon as well? |
|
a friendly reminder @aleksandr-m I was wondering when you plan to release this change. Is there something that is blocking (or something that the updates broke?) that I can help with? |
|
Hi Dennis. The plan was to implement couple long standing feature requests in that release, but I don't have much spare time lately. I will try to find some time in a next few weeks, and if I don't then I'll release next version as it is now. |
implements #369
57 builds in GitHub actions later, finally got this to run.
I reduced it to plexus-utils 1.X vs 3.X: it appears that there were major changes in encoding of parameters before&after.
Especially annoying, my private box is a windows machine & the issues occurred only on Linux/Ubuntu. For a while it seemed to be a CI vs. local issues (is the JDK not installed correctly? maven 3.9.X not installing as expected? Is there an issue with the actions/runners used?), until I reduced it to plexus-utils 1 vs 3.