Skip to content

[Snyk] Security upgrade torch from 1.13.1 to 2.10.0#708

Open
alejandrosuarez wants to merge 1 commit intomainfrom
snyk-fix-058f67358c4ea018f58f1211609e9753
Open

[Snyk] Security upgrade torch from 1.13.1 to 2.10.0#708
alejandrosuarez wants to merge 1 commit intomainfrom
snyk-fix-058f67358c4ea018f58f1211609e9753

Conversation

@alejandrosuarez
Copy link
Owner

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the pip dependencies of this project.

Snyk changed the following file(s):

  • examples/text_to_image/requirements.txt
⚠️ Warning
transformers 4.30.2 requires safetensors, which is not installed.
torchvision 0.14.1 requires torch, which is not installed.
accelerate 0.20.3 requires torch, which is not installed.

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

The following vulnerabilities are fixed by pinning transitive dependencies:
- https://snyk.io/vuln/SNYK-PYTHON-TORCH-15123585
@gemini-code-assist
Copy link

Summary of Changes

Hello @alejandrosuarez, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, focuses on improving the project's security by updating a key dependency. The primary objective is to resolve a known vulnerability within the torch package by specifying a newer, secure version in the requirements.txt file for the text-to-image example.

Highlights

  • Dependency Upgrade: The torch dependency has been upgraded from version 1.13.1 to >=2.10.0 in the examples/text_to_image/requirements.txt file.
  • Security Fix: This upgrade addresses 1 identified vulnerability in the torch package, as automatically detected and reported by Snyk.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@socket-security
Copy link

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Critical
Critical CVE: PyTorch: pypi torch`.load` with `weights_only=True` leads to remote code execution

CVE: GHSA-53q9-r3pm-6pq6 PyTorch: torch.load with weights_only=True leads to remote code execution (CRITICAL)

Affected versions: < 2.6.0

Patched version: 2.6.0

From: examples/research_projects/realfill/requirements.txtpypi/torch@2.2.0

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore pypi/torch@2.2.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Critical
Critical CVE: PyTorch: pypi torch`.load` with `weights_only=True` leads to remote code execution

CVE: GHSA-53q9-r3pm-6pq6 PyTorch: torch.load with weights_only=True leads to remote code execution (CRITICAL)

Affected versions: < 2.6.0

Patched version: 2.6.0

From: examples/server/requirements.txtpypi/torch@2.4.1

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore pypi/torch@2.4.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully addresses a security vulnerability by upgrading the torch dependency to version 2.10.0 or higher. The change is straightforward and directly targets the reported vulnerability.

tensorboard
Jinja2
peft==0.7.0
torch>=2.10.0 # not directly required, pinned by Snyk to avoid a vulnerability

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment "not directly required" is misleading. As indicated in the PR description's warning section, torchvision and accelerate explicitly require torch. It's more accurate to state that torch is a dependency, and this specific version is pinned for security reasons.

torch>=2.10.0 # Pinned by Snyk for security. Required by other dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants