lib/addgrps.c: add_groups(): Simplify redundant code with a goto

Reviewed-by: Serge Hallyn <serge@hallyn.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar · Jan 24, 2025 · a2841ce · a2841ce
1 parent 1fd1bb4
commit a2841ce
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/lib/addgrps.c b/lib/addgrps.c
@@ -88,11 +88,8 @@ add_groups(const char *list)
 	}
 
 	if (added) {
-		int  ret;
-
-		ret = setgroups (ngroups, grouplist);
-		free (grouplist);
-		return ret;
+		if (setgroups(ngroups, grouplist) == -1)
+			goto free_gids;
 	}
 
 	free (grouplist);