About, mail and headset reaction #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/src/main/AndroidManifest.xml
Outdated
| android:supportsRtl="true" | ||
|
|
||
| android:theme="@style/AppTheme"> | ||
| <activity android:name=".ListArtistsActivity"> |
There was a problem hiding this comment.
Плохое имя, т.к. в ней только список.
| mHelper.getWritableDatabase(); | ||
| } | ||
|
|
||
| public void close() { |
There was a problem hiding this comment.
Не надо закрывать. Надо не пересоздавать.
added 3 commits
August 10, 2016 00:18
# Conflicts: # app/build.gradle # app/src/main/java/ru/aleien/yapplication/MainActivity.java # app/src/main/java/ru/aleien/yapplication/dataprovider/WebArtistsProvider.java
Owner
Author
|
Фух. Спасибо за комментарии, большую часть смогла поправить, не получилось пока ArtistsProvider сделать, завтра еще подумаю, как вынести) |
| if (EMAIL_INTENT.resolveActivity(getPackageManager()) != null) { | ||
| startActivity(EMAIL_INTENT); | ||
| } | ||
|
|
There was a problem hiding this comment.
Было бы супер, если бы не было пустых строк там где их точно не должно быть.
ЖДУ ОБНОВЛЕНИЙ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.