Display valid Enum values in Coerce #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
|
Sample message: |
24 tasks
|
Sorry to chase, but is it likely to be considered? Or should it be handled inside Home Assistant? |
|
Seems reasonable. Do the tests pass? I haven't set up CI since Travis died. |
|
They do on my machine: nosetests
.......................................................................................................................................................................................
----------------------------------------------------------------------
Ran 183 tests in 0.088s
OK |
|
Added tests: nosetests --with-coverage --cover-package=voluptuous
........................................................................................................................................................................................
Name Stmts Miss Cover
--------------------------------------------------
voluptuous/__init__.py 6 0 100%
voluptuous/error.py 78 2 97%
voluptuous/humanize.py 22 7 68%
voluptuous/schema_builder.py 509 18 96%
voluptuous/util.py 63 7 89%
voluptuous/validators.py 460 13 97%
--------------------------------------------------
TOTAL 1138 47 96%
----------------------------------------------------------------------
Ran 184 tests in 0.139s
OK |
|
Would you mind formatting this without the list brackets? eg. |
|
Adjusted without the brackets, and added tests for a string enum. nosetests --with-coverage --cover-package=voluptuous
........................................................................................................................................................................................
Name Stmts Miss Cover
--------------------------------------------------
voluptuous/__init__.py 6 0 100%
voluptuous/error.py 78 2 97%
voluptuous/humanize.py 22 7 68%
voluptuous/schema_builder.py 509 18 96%
voluptuous/util.py 63 7 89%
voluptuous/validators.py 460 13 97%
--------------------------------------------------
TOTAL 1138 47 96%
----------------------------------------------------------------------
Ran 184 tests in 0.132s
OK |
|
Perfect, thank you so much! |
|
Thanks 👍 |
|
Let me know when the release is available... |
|
Any luck with the release ? |
|
This broke for py2.7, homepage still lists py2.7 as being supported... what to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.