Add go.mod and time.Time human readable representation #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
approved these changes
Sep 24, 2020
|
Awesome thanks! |
|
CI is failing though. |
SchumacherFM
force-pushed
the
master
branch
from
a33f0fc to
7aeb8a6
Compare
If a struct is time.Time it gets printed as time.Date(...) which hides the private fields of time.Time. Downgrade to testify 1.4 as Go 1.9 is required Remove dependency to testify/assert
SchumacherFM
force-pushed
the
master
branch
from
7aeb8a6 to
d964203
Compare
|
thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It always bugs me how time.Time gets printed ... so here is a fix.
If a struct is time.Time it gets printed as time.Date(...) which
hides the private fields of time.Time.
If you have other suggestions or don't like it. Let me know :-)