Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes, improvements, optimization & refactoring before parser generation #288

Merged
merged 13 commits into from
Dec 5, 2022
Merged

Bug fixes, improvements, optimization & refactoring before parser generation #288

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5fa25c2
Fix bad float conformation error message + add coverage
Aug 13, 2022
2795a9d
Remove duplicit information from int/float conversion errors
petee-d Dec 4, 2022
ad1557e
Fix possible panic when optional groups are used within a capture
petee-d Dec 4, 2022
5e400b6
Improve mismatch error message for negation & negative lookahead group
petee-d Dec 4, 2022
3de599c
Improve the choice of error reporting after optional branches
petee-d Dec 5, 2022
d03a0d2
Optimize string field accumulation to do fewer allocations
Aug 13, 2022
b36c8c7
Optimize finding case insensitive tokens to be done at parser constru…
Aug 13, 2022
bb4e748
Avoid an allocation in newParseContext
petee-d Dec 4, 2022
bf35800
Include explicit disjunction in the union node
petee-d Dec 4, 2022
9aefebf
Remove unused optional and repetition grammar nodes
Nov 7, 2022
8854a6d
Change the receiver name of lookaheadGroup from n to l
petee-d Dec 4, 2022
af8a3d3
Keep track of the number of usages of a strct node
Aug 13, 2022
a61174d
Allow specifying UnexpectedTokenError expected sequence as a string
Aug 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Optimize string field accumulation to do fewer allocations
  • Loading branch information
@petee-d
Peter Dolak authored and petee-d committed Dec 5, 2022
commit d03a0d2c34bd3898863544e7b9b309c5e065e356
7 changes: 6 additions & 1 deletion nodes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,9 +734,14 @@ func setField(tokens []lexer.Token, strct reflect.Value, field structLexerField,
if err != nil {
return err
}
if len(fieldValue) == 0 {
return nil
}
accumulated := f.String()
for _, v := range fieldValue {
f.Set(reflect.ValueOf(f.String() + v.String()).Convert(f.Type()))
accumulated += v.String()
}
f.SetString(accumulated)
return nil
}

Expand Down
3 changes: 2 additions & 1 deletion parser_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,9 @@ func TestRepetitionAcrossFields(t *testing.T) {
}

func TestAccumulateString(t *testing.T) {
type customString string
type testAccumulateString struct {
A string `@"."+`
A customString `@"."+`
}

parser := mustTestParser[testAccumulateString](t)
Expand Down