Adds a failing test for short flags of subcommand not being recognized bug #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been chasing this bug all the weekend, and finally gave up, accepting my golang "newbieness", and humbly sending this PR with the failing test. |
|
@alecthomas if you give me some hint on what could be causing this I can keep trying to solve it. |
|
Interesting, thanks for chasing this up. I'll take a look! |
|
Okay, try it now. After adding many many println's, it dawned on me that perhaps I just wasn't recursively initialising subcommands. Thanks for finding the bug and sending the PR. |
|
@alecthomas your fix worked as expected. thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up a short flag of a nested subcommand, the flag is recognized (when parsing a command line) if used in its long form but not recognized in its short form.
This PR contains only the failing test.