Fix MySQL lexer single comment render error#1214
Merged
alecthomas merged 1 commit intoalecthomas:masterfrom Feb 10, 2026
Merged
Fix MySQL lexer single comment render error#1214alecthomas merged 1 commit intoalecthomas:masterfrom
alecthomas merged 1 commit intoalecthomas:masterfrom
Conversation
JpMand
force-pushed
the
mysql-comments
branch
from
618d91e to
d02ebd3
Compare
Owner
|
Nice, thanks! |
alecthomas
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1213
Removing the mandatory space after
--allowed the regex to correctly parse the inline comments and avoid matching actual code on empty--After (using
chromad --csrf-key=moo):new regex matches the
sql.xmlsingle comment patternchroma/lexers/embedded/sql.xml
Line 15 in 17e5911
I followed the instructions on AGENTS.md for running the project, since I'm never developed with go language, am not familiar with the environment and I couldn't find a build/run instructions elsewhere (since the project seems simple to run, I guess it was not needed).