-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New development-related icons. #107
Conversation
Wow! This was is a big pull request. I'll quickly go through it, and then I'll merge it, thanks! |
@jolkdarr here is my list of comments:
Ok I think for the time being this list is enough. When you will finish these, I will list the rest of the issues :) |
First: thanks for your comments. Mathematica icons were badly handled. Issue fixed by moving:
MIME types fulfill Wolfram specifications (https://reference.wolfram.com/language/ref/format/NB.html). For the application, a new link is added because my (quite old) version (7.0) expects an icon named '''wolfram_mathematica". |
Perl, C++, Scala file icons moved to mimetypes folder. Python file removed (you have provided already a version in apps). |
…hML, XMI, Install).
Fork rebasing
Fork rebasing
Rebase (Godot icon, PR alecive#110).
Master branch update.
Added Lazarus IDE Added PlayOnLinux Added Unity engine Added Unreal engine
Added codeblocks and gitkraken icons
Update with game icons.
@jolkdarr sorry for the delay, I don't know why I didn't notice all your changes up to now. Anyway, coming back to the topic, all these commits are too many to be merged into FlatWoken as-is. If you are still interested into merging your work with the main repository, do you mind splitting them up in more atomic pull requests? If we can discuss about the icons one by one I can provide better feedback and we can merge more quickly. Closing for now. |
Contributions for issue #106.