[issue-30] Create Search Page #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[issue-30] Rebased off main to get changes
Successfully fetches from API and populates teasers
…ing to details page Main functionality working, need to clean up routing and stylings.
… recieve url param
Closed
|
Merge conflicts are due to adding routing to this page as part of this PR, and changing one line in the forms component to match the 's property ( handleClick() => onClick() ). They seem easily resolved when merging. |
looper-m
reviewed
Mar 29, 2021
looper-m
reviewed
Mar 29, 2021
looper-m
reviewed
Mar 29, 2021
* [issue-29] build home * [issue-29] update Layouts and styles Co-authored-by: Alessia Pizzoccheri <pizzoccheri.alessia5@gmail.com>
alecherryy
reviewed
Mar 29, 2021
alecherryy
requested changes
Mar 29, 2021
* [issue-##] update utility classes * [issue-##] add summary to carousel cards Co-authored-by: Alessia Pizzoccheri <pizzoccheri.alessia5@gmail.com>
Co-authored-by: Alessia Pizzoccheri <pizzoccheri.alessia5@gmail.com>
[issue-30] Rebased off main to get changes
Successfully fetches from API and populates teasers
…ing to details page Main functionality working, need to clean up routing and stylings.
[issue-30] Routing and memory of search functional
… recieve url param [issue-30] Search, navigation, and history functional. Edit recipe to recieve url param.
[issue-30] Edit per comments, committing to rebase from main
…alecherryy/cooks-books-app into feature/issue-30-create-search-page-rhg [issue-30] Merge branch to be able to push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A search page per the mockups. Searches using the api, remembers search in the url, and populates teasers with info and has the teasers link to the recipe page with the recipeId from spoonacular.
This component does not work in storybook, I didn't want to add a default call to the API as when the user first goes to the search page, it would give whatever results came from the default. So I added routing to it as part of this PR in order to make sure everything was working.
There are a few things that can be tidier, and a few to-do flags left, but for this assignment due I thought this was in a good place.
I tested this component by running the app itself, not through storybook, as making calls to the API and saving them in the url was part of its functionality.