Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue-05] create Spinning Hero #18

Merged
merged 3 commits into from
Mar 9, 2021
Merged

[issue-05] create Spinning Hero #18

merged 3 commits into from
Mar 9, 2021

Conversation

alecherryy
Copy link
Owner

No description provided.

@alecherryy alecherryy requested a review from rileyhgrant March 5, 2021 03:22
@alecherryy alecherryy linked an issue Mar 5, 2021 that may be closed by this pull request
Create Spinning Image component #5
Closed
@alecherryy alecherryy self-assigned this Mar 5, 2021
rileyhgrant
rileyhgrant approved these changes Mar 8, 2021
View reviewed changes
Copy link
Collaborator

@rileyhgrant rileyhgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only tiny thing is a minor typo in the child component 'spinninng-images__image', spinninng with two 'n's before the g. Definitely doesn't matter at all, but might be confusing if further changes are required?

Also, the readme seems to indicate the person who submitted the PR will review feedback, so I hope the 'approve' feature doesn't auto merge? I guess we'll see.

@alecherryy
Copy link
Owner Author

Looks good! Only tiny thing is a minor typo in the child component 'spinninng-images__image', spinninng with two 'n's before the g. Definitely doesn't matter at all, but might be confusing if further changes are required?

Also, the readme seems to indicate the person who submitted the PR will review feedback, so I hope the 'approve' feature doesn't auto merge? I guess we'll see.

Thank you! My keyboard does that A LOT (double tap) so I appreciate this.

@alecherryy alecherryy merged commit 68ad6c7 into main Mar 9, 2021
@alecherryy alecherryy deleted the feature/issue-05-create-spinning-hero branch March 9, 2021 00:41
rileyhgrant pushed a commit that referenced this pull request Mar 17, 2021
@alecherryy @rileyhgrant
[issue-05] create Spinning Hero (#18)
13e734e 
* [issue-05] create Spinning Hero images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileyhgrant rileyhgrant rileyhgrant approved these changes

Assignees

@alecherryy alecherryy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Spinning Image component
2 participants
@alecherryy @rileyhgrant