forked from souramoo/Needle
-
Notifications
You must be signed in to change notification settings - Fork 12
Open

Description
For me script crashes on "Remounting /system..." step
MENU
1 - Patch file from a device (adb)
2 - Patch file from the input folder
> 1
*** OS: Linux 4.14.9-1-ARCH (linux)
*** Python: 3.6.4 (64 bit)
*** Mode: 1
*** Working dir: /tmp/Tingle-x2vr8_to
*** Selected device: 43f8c4790903
*** Automounting /system...
DEBUG: Already mounted
*** Pulling framework from device...
*** Device SDK: 25
*** Decompressing framework...
DEBUG: Decompressing framework.jar
*** Disassembling classes...
DEBUG: Disassembling framework/classes.dex
*** Patching...
*** Detected: Android 8.x / 7.x / 6.x (or LOS/CM 13-15)
*** Patching succeeded.
*** Reassembling classes...
DEBUG: Assembling out/classes.dex
WARNING: The reassembling has failed (probably we have exceeded the 64K methods limit)
but do NOT worry, we will retry.
*** Moving methods...
WARNING: Experimental code.
DEBUG: Disassembling framework/classes2.dex
*** Reassembling classes...
DEBUG: Assembling out/classes.dex
DEBUG: Assembling out/classes2.dex
*** Recompressing framework...
DEBUG: Compressing framework.jar
*** Copying the patched file to the output folder...
*** Rooting adbd...
DEBUG: adbd cannot run as root in production builds
*** Unlocked ADB: False
*** Remounting /system...
ERROR INFO
==========
Type: <class 'subprocess.CalledProcessError'>
Cmd: ['/usr/bin/adb', '-s', '43f8c4790903', 'shell', "su -c 'mount -o remount,rw /system /system && mount' | grep ' /system '"]
Return code: 1
Output: mount: '/system' not in /proc/mounts
Traceback (most recent call last):
File "./main.py", line 720, in <module>
enable_device_writing(SELECTED_DEVICE)
File "./main.py", line 365, in enable_device_writing
remount_check = safe_output_decode(safe_subprocess_run([DEPS_PATH["adb"], "-s", chosen_device, "shell", "su -c 'mount -o remount,rw /system /system && mount' | grep ' /system '"])) # Untested
File "./main.py", line 203, in safe_subprocess_run
return subprocess.check_output(command, stderr=subprocess.STDOUT)
File "/usr/lib/python3.6/subprocess.py", line 336, in check_output
**kwargs).stdout
File "/usr/lib/python3.6/subprocess.py", line 418, in run
output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['/usr/bin/adb', '-s', '43f8c4790903', 'shell', "su -c 'mount -o remount,rw /system /system && mount' | grep ' /system '"]' returned non-zero exit status 1.
Phone is Xiaomi Redmi Note 4X running AospExtented v4.6/Android 7.1.2, rooted via Magisk if it makes the difference.
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
Metadata
Metadata
Assignees
Labels
No labels