Skip to content

Add missing proxy features to hdf5 crate #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add missing proxy features to hdf5 crate #204

wants to merge 1 commit into from

Conversation

ajtribick
Copy link
Contributor

Proxy features from hdf5-sys crate, since cargo doesn't allow the following:

[dependencies]
hdf5 = { version = "0.8.1", features = ["hdf5-sys/static"] }

@ajtribick ajtribick changed the title Add missing proxy features to hdf5-sys crate Add missing proxy features to hdf5 crate Feb 19, 2022
@mulimoen
Copy link
Collaborator

I think this should wait till we bump MSRV to 1.60 and use weak dependencies. This way it will be less confusing if one specifies zlib, if done as of now this will compile and use the included version of hdf5-c.

We have to specify what a static build should mean. In some instances the hdf5-c library is packaged as a static library which could be used directly. Ought we rename this flag to build-from-source to make this less ambigous?

The hl, threadsafe, deprecated options are only necessary for users that use hdf5-sys indirectly (such as georust/netcdf), and they need not be proxied.

Finally: This has a workaround which is including hdf5-sys yourself in your Cargo.toml and specifying exactly how you want the library built.

@ajtribick ajtribick closed this Feb 19, 2022
@ajtribick ajtribick deleted the proxy-features branch February 19, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants