Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Skip attachments without any content for events #5110

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Skip attachments without any content for events #5110

merged 2 commits into from
Jan 24, 2024

Conversation

meain
Copy link
Member

@meain meain commented Jan 24, 2024 •
edited
Loading

Known issue, tracking in #4772

Does this PR need a docs update or release note?

  • ✅ Yes, it's included
  • 🕐 Yes, but in a later PR
  • ⛔ No

Type of change

  • 🌻 Feature
  • 🐛 Bugfix
  • 🗺️ Documentation
  • 🤖 Supportability/Tests
  • 💻 CI/Deployment
  • 🧹 Tech Debt/Cleanup

Issue(s)

  • #

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@meain meain self-assigned this Jan 24, 2024
@aviator-app Aviator app
Copy link
Contributor

aviator-app bot commented Jan 24, 2024 •
edited
Loading

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

pandeyabs
pandeyabs approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@pandeyabs pandeyabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a unit test case for this later. I'll move this forward meanwhile.

@pandeyabs pandeyabs added export All operations that deal with data export mergequeue labels Jan 24, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@aviator-app aviator-app bot merged commit c526ced into main Jan 24, 2024
24 checks passed
@aviator-app aviator-app bot deleted the event-item-attachment-skip branch January 24, 2024 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pandeyabs pandeyabs pandeyabs approved these changes

@HiteshRepo HiteshRepo Awaiting requested review from HiteshRepo

Assignees

@meain meain

Labels
export All operations that deal with data export mergequeue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meain @pandeyabs