Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

[Bug]: some data still unmasked when --mask-sensitive-data passed #3895

Open
ashmrtn opened this issue Jul 24, 2023 · 0 comments
Open

[Bug]: some data still unmasked when --mask-sensitive-data passed #3895

ashmrtn opened this issue Jul 24, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers supportability

Comments

@ashmrtn
Copy link
Contributor

ashmrtn commented Jul 24, 2023

What happened?

when using the --mask-sensitive-data flag some information like the user display name (for OneDrive/Exchange) is still visible. For full and incremental backup shows the user display name still appears when connecting to the repo (progress output) and at the end of the run (unclear what's printing it)

Additionally, the tenant ID and user ID is found in some places in the logs when printing collection info/info about items being backed up

Corso Version?

Corso v0.11.1 dev

Where are you running Corso?

N/A

Relevant log output

No response

@ashmrtn ashmrtn added bug Something isn't working supportability labels Jul 24, 2023
aviator-app bot pushed a commit that referenced this issue Jul 25, 2023
#### Does this PR need a docs update or release note?

- [ ] ✅ Yes, it's included
- [ ] 🕐 Yes, but in a later PR
- [x] ⛔ No

#### Type of change

- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Supportability/Tests
- [ ] 💻 CI/Deployment
- [x] 🧹 Tech Debt/Cleanup

#### Issue(s)

* #3895

#### Test Plan

- [x] 💪 Manual
- [ ] ⚡ Unit test
- [ ] 💚 E2E
aviator-app bot pushed a commit that referenced this issue Jul 28, 2023
Pull in fix for double hashing some values

----

#### Does this PR need a docs update or release note?

- [ ] ✅ Yes, it's included
- [ ] 🕐 Yes, but in a later PR
- [x] ⛔ No

#### Type of change

- [ ] 🌻 Feature
- [x] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [x] 🤖 Supportability/Tests
- [ ] 💻 CI/Deployment
- [x] 🧹 Tech Debt/Cleanup

#### Issue(s)

* #3895

#### Test Plan

- [x] 💪 Manual
- [ ] ⚡ Unit test
- [ ] 💚 E2E
aviator-app bot pushed a commit that referenced this issue Jul 31, 2023
Reuse existing Elements code to conceal information.

---

#### Does this PR need a docs update or release note?

- [ ] ✅ Yes, it's included
- [ ] 🕐 Yes, but in a later PR
- [x] ⛔ No

#### Type of change

- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Supportability/Tests
- [ ] 💻 CI/Deployment
- [x] 🧹 Tech Debt/Cleanup

#### Issue(s)

* #3895

#### Test Plan

- [x] 💪 Manual
- [ ] ⚡ Unit test
- [ ] 💚 E2E
aviator-app bot pushed a commit that referenced this issue Jul 31, 2023
Add better handling for
* hiding possibly sensitive data when logging
* adding possibly sensitive data to context clues
* adding context clues to returned errors

---

#### Does this PR need a docs update or release note?

- [ ] ✅ Yes, it's included
- [ ] 🕐 Yes, but in a later PR
- [x] ⛔ No

#### Type of change

- [ ] 🌻 Feature
- [ ] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Supportability/Tests
- [ ] 💻 CI/Deployment
- [x] 🧹 Tech Debt/Cleanup

#### Issue(s)

* #3895

#### Test Plan

- [x] 💪 Manual
- [ ] ⚡ Unit test
- [ ] 💚 E2E
@vkamra vkamra added the good first issue Good for newcomers label Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers supportability
Projects
None yet
Development

No branches or pull requests

2 participants