feat: add initial smart wallet client actions #1648
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
moldy530
force-pushed
the
moldy/wallet-api-base
branch
from
5ba93d5 to
5a87789
Compare
| }, | ||
| // TODO: we can probably do away with some of the if-else logic here and just convert the params to creation hints | ||
| // and pass them to the client | ||
| return smartWalletClient |
There was a problem hiding this comment.
This is probably the most beneficial place to add support for wallet apis because it means accounts will be index correctly. everything downstream will the touch this flow which is what we want
moldy530
force-pushed
the
moldy/wallet-api-base
branch
2 times, most recently
from
6ae679e to
03078f3
Compare
| TAccount extends JsonRpcAccount<Address> | undefined = | ||
| | JsonRpcAccount<Address> | ||
| | undefined, | ||
| > = { mode?: "local" | "remote" } & (IsUndefined<TAccount> extends true |
There was a problem hiding this comment.
actually, we should move the mode into the config rather than here
There was a problem hiding this comment.
i do this in a later pr
account-kit/core/src/experimental/actions/getSmartWalletClient.ts
Outdated
Show resolved
Hide resolved
moldy530
force-pushed
the
moldy/wallet-api-base
branch
from
03078f3 to
126aa8a
Compare
moldy530
force-pushed
the
moldy/wallet-api-base
branch
from
126aa8a to
895fe14
Compare
moldy530
force-pushed
the
moldy/wallet-api-base
branch
from
895fe14 to
85be9fa
Compare
🌿 Documentation Preview
|
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR introduces an experimental namespace for actions utilizing Wallet APIs and adds a
SignerNotConnectedErrorclass. It enhances the state management for smart wallet clients and updates the configuration and account creation processes to integrate with the new smart wallet functionality.Detailed summary
# Experimentalsection inREADME.md.SignerNotConnectedErrorclass inerrors.ts.index.tsto export new actions for smart wallet clients.store.tsandtypes.tsto managesmartWalletClientsstate.package.jsonfor wallet-client dependencies.watchSmartWalletClientaction inwatchSmartWalletClient.ts.createConfigto includeaccountCreationHint.useSmartWalletClienthook inhooks/useSmartWalletClient.ts.getSmartWalletClientto handle connection checks and state management.createAccount.tsto utilize smart wallet client.