Skip to content

feat: splitting signing methods into prepare and sign #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

howydev
Copy link
Collaborator

@howydev howydev commented May 19, 2025

Pull Request Checklist


PR-Codex overview

This PR focuses on enhancing the signing methods for accounts in the smart contract system by introducing prepareSign and formatSign methods, improving error handling, and ensuring compatibility with different signature request types.

Detailed summary

  • Added assertNeverSignatureRequestType function to handle invalid signature request types.
  • Introduced prepareSign and formatSign methods in various components for consistent signature handling.
  • Updated signMessage and signTypedData methods to utilize the new signing methods.
  • Enhanced error messages for unsupported versions.
  • Modified SignatureRequest and SigningMethods types to accommodate new functionality.
  • Improved handling of deferred actions in signing methods.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented May 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2025 1:09am

Copy link

github-actions bot commented May 19, 2025

🌿 Documentation Preview

Name Status Preview Updated (UTC)
Alchemy Docs ✅ Ready 🔗 Visit Preview Jun 3, 2025, 1:05 AM

@github-actions github-actions bot temporarily deployed to docs-preview May 19, 2025 16:22 Inactive
@github-actions github-actions bot temporarily deployed to docs-preview May 19, 2025 18:28 Inactive
@github-actions github-actions bot temporarily deployed to docs-preview May 21, 2025 00:36 Inactive
@github-actions github-actions bot temporarily deployed to docs-preview May 21, 2025 17:35 Inactive
@howydev howydev marked this pull request as ready for review May 21, 2025 17:36
@github-actions github-actions bot temporarily deployed to docs-preview May 21, 2025 18:25 Inactive
@howydev howydev force-pushed the howy/split-signing-methods branch from a33fb15 to 125311e Compare May 21, 2025 18:25
@github-actions github-actions bot temporarily deployed to docs-preview May 21, 2025 18:26 Inactive
@howydev howydev force-pushed the howy/split-signing-methods branch from 125311e to 31073b5 Compare May 21, 2025 18:29
@github-actions github-actions bot temporarily deployed to docs-preview May 21, 2025 18:29 Inactive
@howydev howydev force-pushed the howy/split-signing-methods branch from 3741625 to 4019279 Compare May 29, 2025 21:27
@github-actions github-actions bot temporarily deployed to docs-preview May 29, 2025 21:27 Inactive
@github-actions github-actions bot temporarily deployed to docs-preview May 30, 2025 17:33 Inactive
@github-actions github-actions bot temporarily deployed to docs-preview June 2, 2025 18:40 Inactive
@github-actions github-actions bot temporarily deployed to docs-preview June 2, 2025 18:56 Inactive
@github-actions github-actions bot had a problem deploying to docs-preview June 2, 2025 20:10 Failure
@github-actions github-actions bot had a problem deploying to docs-preview June 2, 2025 20:26 Failure
@howydev howydev force-pushed the howy/split-signing-methods branch from 9a580d6 to 350aa2b Compare June 2, 2025 20:28
@github-actions github-actions bot had a problem deploying to docs-preview June 2, 2025 20:29 Failure
@github-actions github-actions bot had a problem deploying to docs-preview June 2, 2025 20:29 Failure
@github-actions github-actions bot temporarily deployed to docs-preview June 3, 2025 01:04 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants