-
Notifications
You must be signed in to change notification settings - Fork 170
feat: splitting signing methods into prepare and sign #1629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
howydev
wants to merge
10
commits into
main
Choose a base branch
from
howy/split-signing-methods
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🌿 Documentation Preview
|
Blu-J
reviewed
May 19, 2025
a33fb15
to
125311e
Compare
125311e
to
31073b5
Compare
3741625
to
4019279
Compare
9a580d6
to
350aa2b
Compare
howydev
commented
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR focuses on enhancing the signing methods for accounts in the smart contract system by introducing
prepareSign
andformatSign
methods, improving error handling, and ensuring compatibility with different signature request types.Detailed summary
assertNeverSignatureRequestType
function to handle invalid signature request types.prepareSign
andformatSign
methods in various components for consistent signature handling.signMessage
andsignTypedData
methods to utilize the new signing methods.SignatureRequest
andSigningMethods
types to accommodate new functionality.