perf(ci): build and deploy pipeline optimizations - #115
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the integration-test Docker build flow by keeping the Rust toolchain version aligned between rust-toolchain.toml and the integration Docker images, reducing redundant toolchain downloads during image builds.
Changes:
- Export
RUST_VERSIONfromrust-toolchain.tomlvia theMakefileso downstream tooling can reuse it. - Parameterize the integration client/server Dockerfiles with a
RUST_VERSIONbuild-arg. - Wire
RUST_VERSIONthroughdocker-compose.ymlbuild args for both integration services.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Makefile | Exports RUST_VERSION derived from rust-toolchain.toml for use by docker compose builds. |
| crates/oapi-codegen/tests/integration/server/Dockerfile | Uses RUST_VERSION-based Rust image tag; adjusts build/copy paths accordingly. |
| crates/oapi-codegen/tests/integration/docker-compose.yml | Passes RUST_VERSION into server/client image builds via build args. |
| crates/oapi-codegen/tests/integration/client/Dockerfile | Uses RUST_VERSION-based Rust image tag for the test runner build stage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
🎉 This PR is included in version 1.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.