Skip to content
This repository has been archived by the owner on Sep 4, 2018. It is now read-only.

fix detail button opacity animations #90

Merged
merged 7 commits into from
Nov 21, 2013
Merged

Conversation

jurre
Copy link
Collaborator

@jurre jurre commented Nov 20, 2013

When highlighting a cell:

screen shot 2013-11-19 at 17 16 58

When highlighting a button:

screen shot 2013-11-19 at 17 17 25

@jurre
Copy link
Collaborator Author

jurre commented Nov 20, 2013

What do you think? Might be a little too much with all the buttons right? Maybe we should hide them completely until hovering over the cell? @orta what do you think?

@jurre
Copy link
Collaborator Author

jurre commented Nov 20, 2013

referencing #77

@orta
Copy link
Contributor

orta commented Nov 20, 2013

Hide them completely unless hovering, think it's a pretty simple way to deal with it. Is there a maximum of two items there? Might make sense to move them to be above each other.

@jurre
Copy link
Collaborator Author

jurre commented Nov 20, 2013

Changed it to only show the buttons when hovering over the cell, think I prefer this:

screen shot 2013-11-20 at 09 00 39

@jurre
Copy link
Collaborator Author

jurre commented Nov 20, 2013

Yeah currently there's only 2 items max, let me try stacking them vertically like you said and see what that looks like

@jurre
Copy link
Collaborator Author

jurre commented Nov 20, 2013

screen shot 2013-11-20 at 09 10 03

Thoughts?

@orta
Copy link
Contributor

orta commented Nov 20, 2013

I had a think about this and ended up thinking that this is probably a clearer way to do it ( #91 )

screen shot 2013-11-20 at 12 06 12

So there's always a link to the project, and it feels like it will open else-where. Then the preview is shown at the other side next to the plugin type meaning there is a consistency in the overall cell.

@jurre
Copy link
Collaborator Author

jurre commented Nov 20, 2013

I like the way that looks, but won't it be confusing for users to have those actions be in different places?

Sent from my iPhone

On 20 nov. 2013, at 09:42, Orta notifications@github.com wrote:

I had a think about this and ended up thinking that this is probably a clearer way to do it ( #91 )


Reply to this email directly or view it on GitHub.

@orta
Copy link
Contributor

orta commented Nov 20, 2013

The way I perceive it, one is an in-window action (loading quick look), the other is a move to the next step style action ( open safari at the repo. )

I guess it could have the two vertically balanced in the centre on the right, open trying that first?

@supermarin
Copy link
Collaborator

Hm, preview on the left doesn't look right to my designer-untalented eye

@jurre
Copy link
Collaborator Author

jurre commented Nov 20, 2013

@orta you mean like this?

screen shot 2013-11-20 at 14 09 28

And then if there's only one option it'll also align center?

@orta
Copy link
Contributor

orta commented Nov 20, 2013

yeah, exactly

@jurre
Copy link
Collaborator Author

jurre commented Nov 20, 2013

Yeah that could work! @mneorr @kattrali what do you guys think?

btw @orta you think we should use that arrow icon over the current one for linking to the project home page?

@orta
Copy link
Contributor

orta commented Nov 20, 2013

Yeah, I think so, it's based off the one in Xcode itself

screen shot 2013-11-20 at 17 19 20

@orta
Copy link
Contributor

orta commented Nov 20, 2013

might work better inverted though, hard to quantify.

@jurre
Copy link
Collaborator Author

jurre commented Nov 20, 2013

Yeah that makes sense :) Do you happen to have the assets for that?

@orta
Copy link
Contributor

orta commented Nov 20, 2013

I will create them now.

@orta
Copy link
Contributor

orta commented Nov 20, 2013

open_website 2x
open_website

If they feel too small I can make them bigger. Currently 14x14

@jurre
Copy link
Collaborator Author

jurre commented Nov 21, 2013

No it actually looks pretty good like this even though the other icon is 16x16:

screen shot 2013-11-20 at 16 36 21

Let me just properly align them when there's only 1 icon

@jurre
Copy link
Collaborator Author

jurre commented Nov 21, 2013

Done :)

screen shot 2013-11-20 at 17 01 09

What do you guys think?

supermarin pushed a commit that referenced this pull request Nov 21, 2013
fix detail button opacity animations
@supermarin supermarin merged commit c9f63af into master Nov 21, 2013
@supermarin supermarin deleted the detailsbuttons-highlight branch November 21, 2013 06:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants