Story of layout PR #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>
albertusdev
pushed a commit
to albertusdev/devtools
that referenced
this pull request
Oct 25, 2019
… for details tree, and several minor changes. - Create proper deserializer method for flex properties from DiagnosticsNode - Create new flag (`isExperimentalStoryOfLayoutEnabled`) in `InspectorTreeFlutterController` to prevent showing all this features changes until my PR (github.com/albertusdev/flutter/pull/2) is landed to Flutter main repository - Inspector details tree now live inside of Tabs! User can focus on layout details instead if they want to. - Removed animation from DianogsticsNodeDescriptions for now (due to minor performance concerns and adding new flag, might add it later!) - Changed hardcoded constants for Buttons in InspectorScreen to prevent button groups expanding to two lines
albertusdev
pushed a commit
to albertusdev/devtools
that referenced
this pull request
Oct 25, 2019
… for details tree, and several minor changes. - Create proper deserializer method for flex properties from DiagnosticsNode - Create new flag (`isExperimentalStoryOfLayoutEnabled`) in `InspectorTreeFlutterController` to prevent showing all this features changes until my PR (github.com/albertusdev/flutter/pull/2) is landed to Flutter main repository - Inspector details tree now live inside of Tabs! User can focus on layout details instead if they want to. - Removed animation from DianogsticsNodeDescriptions for now (due to minor performance concerns and adding new flag, might add it later!) - Changed hardcoded constants for Buttons in InspectorScreen to prevent button groups expanding to two lines
added 4 commits
October 25, 2019 18:25
…roperties method Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>
…ic to another method Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>
albertusdev
pushed a commit
to flutter/devtools
that referenced
this pull request
Oct 30, 2019
* Show constraints next to Widget in Summary Tree * Highlight children's constraints that got unconstrained, highlight parent widget that did the unconstraining, and add animation * Very early prototype of 'Story of Your Flex Widget' dialog * - Avoid using hardcoded color and instead use Color from Theme (to support Light/Dark theme) - Remove hack in InspectorTree node - Remove wrong import - Rename 'Story of your Flex widget' to 'Story of the layout of your Row/Column widget' * Added experimental flag for story of layout feature changes, add tabs for details tree, and several minor changes. - Create proper deserializer method for flex properties from DiagnosticsNode - Create new flag (`isExperimentalStoryOfLayoutEnabled`) in `InspectorTreeFlutterController` to prevent showing all this features changes until my PR (github.com/albertusdev/flutter/pull/2) is landed to Flutter main repository - Inspector details tree now live inside of Tabs! User can focus on layout details instead if they want to. - Removed animation from DianogsticsNodeDescriptions for now (due to minor performance concerns and adding new flag, might add it later!) - Changed hardcoded constants for Buttons in InspectorScreen to prevent button groups expanding to two lines * Remove debugLayoutModeEnabled from DiagnosticsNodeDescription * Change isExperimentalStoryOfLayoutEnabled default value to false * Revert diagnostics.dart * Revert spreading getServiceExtensionWidgets() in Flutter InspectorScreen * Remove unnecessary isSummaryTreeNode field in InspectorTreeNode constructor * Display tab by default and fix code style and formatting * Port story of flex widget to Tab * Align expandCollapseButtons in the same row with the TabBar * Rename layout_tab to inspector_screen_details_tab * Partial highlight constraint and change deserialize method of FlexProperties * Minor cleanups - Stop exposing InspectorController in InspectorTreeControllerFlutter - Remove shouldHighlightConstraint getter since it is unnecessary now - Rename some variable names - Add copyright in new files * Add todos * Add simple widget tests and handle case when Flex element does not have children * Extended EnumDeserializer to contain reverse lookup and rename it to EnumUtils instead * Cleanup & listen to InspectorController instead of TreeControllerFlutter * Remove todo * Remove InspectorControllerClient implementation in LayoutDetailsTab * Rename deserializer to enum utils and make enum utils private * Remove redundant method calls * Stop passing InspectorController to InspectorTree flutter - Add todos - Rename toName & toEnum to name and enum - Minor cleanups * Add TODO * Remove redundant comment
added 15 commits
November 5, 2019 12:18
…to story-of-layout
…egate' of github.com:albertusangga/flutter into story-of-layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Albertus Angga Raharja albertusangga@google.com
Description
Flutter framework changes required for Story of Layout features https://github.com/albertusangga/devtools/pull/1/files
Related Issues
Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR.
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?