Window switcher breaks looking up windows when an unknown window class exists #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Issue * If an unknown window class exists, window-switcher extension will be broken ``` $ wmctrl -l -x 0x05800008 0 N/A hackartist-archlinux Emulator 0x05800005 0 N/A hackartist-archlinux Android Emulator - femu:5554 ``` * Therefore, this PR wraps `handleQuery` with error handling. * Practically, splitting window class raises an error. * However, I would say that the kind of crash can be raised on others. * That is why I wraps the whole code with `try-except`
|
Please continue any discussion here: https://github.com/orgs/albertlauncher/discussions/1299 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handleQuerywith error handling.try-except