pass-9: remove "Podman Desktop" from install copy; re-score rubric rows 2 and 13#56
Open
albertdobmeyer wants to merge 1 commit into
Open
pass-9: remove "Podman Desktop" from install copy; re-score rubric rows 2 and 13#56albertdobmeyer wants to merge 1 commit into
albertdobmeyer wants to merge 1 commit into
Conversation
MissingRuntimeCard macOS/Windows body text no longer names "Podman Desktop" — now reads "the sandbox engine" (download URL unchanged). Closes the last P1 gap on row 2 (8.4 → 8.6). Adds "Podman Desktop" to the BANNED_TERMS enforcement array in user-facing.spec.ts so the product name can't quietly re-appear on any user-visible surface. Also re-scores row 13 (ErrorBoundary) from 6.6 to 9.0 in the rubric, recording the spec-06 failure cascade (FriendlyRetry / ContactSupport / per-class classifyError) that shipped as part of v0.4 (PR #49). The improvement was already in the codebase; the rubric update makes the score match reality. https://claude.ai/code/session_01SBrqXDx4zBmvHxvD6tsNTL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
app/src/components/wizard/install-step/MissingRuntimeCard.tsx"Download Podman Desktop and run the installer."→"Download the sandbox engine and run the installer."https://podman-desktop.io/downloads) is unchanged on both platforms — the link still goes to the right place.app/e2e/user-facing.spec.ts"Podman Desktop"to theBANNED_TERMSarray (29 terms total, was 28).docs/specs/2026-04-20-ux-principles-rubric.mdclassifyError) that shipped as part of v0.4 (PR feat(v0.4): shell/tenant architectural reframe #49). The code improvement was already in the codebase; this re-score makes the rubric match reality.docs/handoff.mdBefore / after rubric scores
Step 1 triage — no external signal yet
git log --since=2026-05-02: v0.4 shell/tenant reframe landed onmain(PR feat(v0.4): shell/tenant architectural reframe #49 merged). No urgent fixes changing priorities.Proceeding from queued candidates per the pass-9 brief.
Candidate selection
Default candidate was ErrorBoundary friendlier copy (row 13, 6.6 → ≥8.5). On inspection, that work was already done: the spec-06 failure cascade (
FriendlyRetry/ContactSupport/ per-classclassifyError) shipped as part of the v0.4 implementation between the v0.3.0 ship date and this session. The code fully satisfies the Pass 9 spec; only the rubric score was stale.Next candidate: macOS / Windows install copy (row 2). "Podman Desktop" still appeared in the
bodytext of the macOS and WindowsRECIPESentries inMissingRuntimeCard.tsx. The fix is the two-line copy change above, plus the banned-term guard.Verification gates
cd app && npm test -- --runcd app && npx tsc --noEmitcd app && npm run buildcd app/src-tauri && cargo test --libgdk-3.0system lib absent in dev container. No Rust files touched in this PR; CI will validate.cd app && npx playwright testbash tests/orchestrator-check.shThe three env blockers are pre-existing in this container and affect zero files changed by this PR (no Rust, no manifests, no schema).
Banned-term count
29 terms enforced (was 28). New term:
"Podman Desktop". Seeapp/e2e/user-facing.spec.tsfor the full list and rationale comments.Reference
Pass 9 candidate list:
docs/specs/2026-05-02-pass-8-preship-walk.mdPart 5https://claude.ai/code/session_01SBrqXDx4zBmvHxvD6tsNTL
Generated by Claude Code