-
Notifications
You must be signed in to change notification settings - Fork 23
Hot reloading #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Hot reloading #18
Conversation
Got this behavior when testing it. |
Doesn't happen for me (Win 10). What happens if you change the Example.val prop in index.js? index.js: import React, { Component } from "react";
import { App, Window, render, Box } from "proton-native";
import { Example } from "./app.js";
class HotApp extends Component {
render() {
return (
<App>
<Example val="sf123sdfd"/>
</App>
);
}
}
render(<HotApp />); app.js import React, { Component, PureComponent } from "react";
import { Box, TextInput, Text, Window } from "proton-native";
class Example extends PureComponent {
render() {
return (
<Window title="Notedssds" size={{ w: 500, h: 350 }} margined>
<Box padded>
<TextInput />
<Text>asddd</Text>
<Text>{this.props.val}</Text>
</Box>
</Window>
);
}
}
export { Example }; |
Will tell you as soon as I get home! Thanks @mischnic !!! |
your example works as expected. The generated placeholder doesn't. Another thing, when running |
Haven't noticed that before.
Could you please be more specific? For me:
The window closes and a new one opens (with the changes).
Everything updates correctly in the current window. |
@mischnic What I meant was, the example you provided, works, ie. windows don't dont replicate for every state change, and the changes are reflected, but the initial boilerplate code, that is generated when you use create-proton-app, does replicate the windows when you save a change (as the picture shows). |
hey, @mischnic send me an email to (the one in my bio), I wanna discuss something. |
Currently fixing a problem with window reloading in: kusti8/proton-native#180
Is
npm run dev
fine as the hot-reloading command?