Skip to content

fix: check when expression correctly #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JounQin merged 2 commits into from
Jun 6, 2025
Merged

fix: check when expression correctly #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
691d73c
fix: check `when` expression correctly
JounQin Jun 6, 2025
d7bcd12
Create proud-masks-kiss.md
JounQin Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/proud-masks-kiss.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@alauda/doom": patch
---

fix: check `when` expression correctly
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"version": "changeset version && yarn --no-immutable"
},
"dependencies": {
"@cspell/eslint-plugin": "^9.0.2",
"@cspell/eslint-plugin": "^8.19.4 || ^9.0.2",
"@eslint-react/eslint-plugin": "^1.51.0",
"@inquirer/prompts": "^7.5.3",
"@openapi-contrib/openapi-schema-to-json-schema": "^5.1.0",
Expand Down Expand Up @@ -98,6 +98,7 @@
"swagger2openapi": "^7.0.8",
"tinyglobby": "^0.2.14",
"type-fest": "^4.41.0",
"typescript": "^5.8.3",
"typescript-eslint": "^8.33.1",
"x-fetch": "^0.2.6",
"yaml": "^2.8.0",
Expand Down Expand Up @@ -129,7 +130,6 @@
"prettier-plugin-properties": "^0.3.0",
"simple-git-hooks": "^2.13.0",
"type-coverage": "^2.29.7",
"typescript": "^5.8.3",
"yarn-berry-deduplicate": "^6.1.3"
},
"publishConfig": {
Expand Down
2 changes: 1 addition & 1 deletion src/cli/new.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ export const newCommand = new Command('new')
const target = path.resolve(render(layout.target, { parameters }))
const when = layout.when && render(layout.when, { parameters })

if (JS_STR_FALSY_VALUES.has(when)) {
if (when != null && JS_STR_FALSY_VALUES.has(when)) {
continue
}

Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ __metadata:
dependencies:
"@changesets/changelog-github": "npm:^0.5.1"
"@changesets/cli": "npm:^2.29.4"
"@cspell/eslint-plugin": "npm:^9.0.2"
"@cspell/eslint-plugin": "npm:^8.19.4 || ^9.0.2"
"@eslint-react/eslint-plugin": "npm:^1.51.0"
"@eslint/js": "npm:^9.28.0"
"@inquirer/prompts": "npm:^7.5.3"
Expand Down Expand Up @@ -1154,7 +1154,7 @@ __metadata:
languageName: node
linkType: hard

"@cspell/eslint-plugin@npm:^9.0.2":
"@cspell/eslint-plugin@npm:^8.19.4 || ^9.0.2":
version: 9.0.2
resolution: "@cspell/eslint-plugin@npm:9.0.2"
dependencies:
Expand Down