Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slow-readers-work.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@alauda/doom": patch
---

chore: enable `@eslint-react/eslint-plugin`, fix related reports
8 changes: 7 additions & 1 deletion eslint.config.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// @ts-check

import eslint from '@eslint/js'
import react from '@eslint-react/eslint-plugin'
import { createTypeScriptImportResolver } from 'eslint-import-resolver-typescript'
import { importX } from 'eslint-plugin-import-x'
import * as reactHooks from 'eslint-plugin-react-hooks'
Expand All @@ -13,10 +14,15 @@ export default config(
eslint.configs.recommended,
importX.flatConfigs.recommended,
importX.flatConfigs.typescript,
react.configs.recommended,
reactHooks.configs['recommended-latest'],
{
files: ['**/*.{ts,tsx}'],
extends: [configs.eslintRecommended, configs.strictTypeChecked],
extends: [
configs.eslintRecommended,
configs.strictTypeChecked,
react.configs['recommended-type-checked'],
],
languageOptions: {
parserOptions: {
projectService: true,
Expand Down
1 change: 1 addition & 0 deletions src/global/VersionsNav/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ const VersionsNav_ = () => {
})
const newNavMenu = getNavMenu()
if (newNavMenu !== navMenu) {
// eslint-disable-next-line @eslint-react/hooks-extra/no-direct-set-state-in-use-effect
setNavMenu(newNavMenu)
} else if (navMenu.parentNode) {
observer.observe(navMenu.parentNode, { childList: true })
Expand Down
1 change: 1 addition & 0 deletions src/runtime/components/K8sCrd.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export const K8sCrdSchemaPart = ({
}, [])

useEffect(() => {
// eslint-disable-next-line @eslint-react/hooks-extra/no-direct-set-state-in-use-effect
setOpen(expandAll)
}, [expandAll])

Expand Down
15 changes: 12 additions & 3 deletions src/runtime/components/OpenAPIPath.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,19 @@ export const OpenAPIParameters = ({
typeNode = <RefLink $ref={type.$ref} />
}
return (
// eslint-disable-next-line @eslint-react/no-array-index-key
<X.li key={index}>
<code>{paramObj.name}</code>(<em>in {paramObj.in}</em>): {typeNode}
{paramObj.required && <Badge>required</Badge>}
<Markdown>{paramObj.description}</Markdown>
<code>{paramObj.name}</code> (<em>in {paramObj.in}</em>): {typeNode}
{paramObj.required && (
<>
{' '}
<Badge>required</Badge>
</>
)}
<>
{' '}
<Markdown>{paramObj.description}</Markdown>
</>
</X.li>
)
})}
Expand Down
4 changes: 2 additions & 2 deletions src/runtime/components/OpenAPIRef.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@ export const OpenAPIProperties = ({
const [X] = useState(getCustomMDXComponent)
return (
<X.ul>
{Object.entries(properties).map(([name, property], index) => (
<X.li key={index}>
{Object.entries(properties).map(([name, property]) => (
<X.li key={name}>
<OpenAPIProperty name={name} property={property} openapi={openapi} />
</X.li>
))}
Expand Down
2 changes: 2 additions & 0 deletions src/runtime/components/Tabs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ export const Tabs: ForwardRefExoticComponent<
return (
<div className="doom-tabs" ref={ref}>
{isPrint ? (
// eslint-disable-next-line @eslint-react/no-children-map
Children.map(children, (child, index) => (
// eslint-disable-next-line @eslint-react/no-array-index-key
<Tabs_ key={index} {...props}>
{child}
</Tabs_>
Expand Down
1 change: 1 addition & 0 deletions src/runtime/components/TermsTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export const TermsTable = ({ terms }: TermsTableProps) => {
list?.length ? (
<X.ul>
{list.map((item, index) => (
// eslint-disable-next-line @eslint-react/no-array-index-key
<X.li key={index}>{item}</X.li>
))}
</X.ul>
Expand Down
1 change: 1 addition & 0 deletions src/runtime/components/_HeadingTitle.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export const HeadingTitle = ({
const HeadingComponent = HeadingComponents[level]
const slugFromChildren = useMemo(
() =>
// eslint-disable-next-line @eslint-react/no-children-to-array
Children.toArray(children)
.filter((it) => typeof it === 'string')
.join(''),
Expand Down