fix: boolean value parsing #36

JounQin · 2025-05-29T13:28:48Z

Summary by CodeRabbit

Bug Fixes
- Improved boolean value parsing in CLI options to better handle cases where options are provided without explicit values.
Enhancements
- Increased the temperature setting for AI-generated translations, allowing for slightly more varied translation outputs.

changeset-bot · 2025-05-29T13:28:52Z

🦋 Changeset detected

Latest commit: b4b7d81

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@alauda/doom	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-05-29T13:28:56Z

Walkthrough

This update introduces a patch changeset for the @alauda/doom package, adjusts the boolean parsing logic in CLI helpers to treat undefined as true, refines the CLI option parsing for --edit-repo, and slightly increases the temperature parameter in the OpenAI translation function to allow for more varied outputs.

Changes

File(s)	Change Summary
.changeset/modern-knives-care.md	Added a changeset documenting a patch update for a boolean parsing fix in `@alauda/doom`.
src/cli/helpers.ts	Changed `parseBoolean` to accept `string
src/cli/index.ts	Updated CLI option parsing for `-R, --edit-repo` to treat absence of value as `true` and refined logic.
src/cli/translate.ts	Increased OpenAI chat completion `temperature` from 0 to 0.1.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CLI
    participant Helpers
    participant OpenAI

    User->>CLI: Run CLI with -R/--edit-repo option
    CLI->>Helpers: parseBoolean(value?)
    Helpers-->>CLI: Returns true if value is undefined or not falsy
    CLI->>OpenAI: If translate command, send request with temperature=0.1
    OpenAI-->>CLI: Returns translation result

Possibly related PRs

feat: add editRepoBaseUrl config and -R, --edit-repo cli flag support #9: Refined the parsing logic for the -R, --edit-repo CLI flag, which this PR further updates to handle optional string input and changes the default boolean interpretation.

Poem

A patch for the knives, so modern and bright,
Now booleans parse with a little more light.
Undefined means true, CLI clearer than ever,
And translations gain flair, just a touch more clever.
🐇✨
Hopping ahead, with code set just right!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 14cdc3e and b4b7d81.

📒 Files selected for processing (4)

.changeset/modern-knives-care.md (1 hunks)
src/cli/helpers.ts (1 hunks)
src/cli/index.ts (1 hunks)
src/cli/translate.ts (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (2)

src/cli/helpers.ts (1)

src/shared/constants.ts (1)

FALSY_VALUES (3-13)

src/cli/index.ts (1)

src/shared/constants.ts (2)

FALSY_VALUES (3-13)

TRUTHY_VALUES (15-15)

🔇 Additional comments (2)

.changeset/modern-knives-care.md (1)

1-6: LGTM! Changeset properly documents the boolean parsing fix.

The changeset correctly documents this as a patch release for the boolean value parsing fix, aligning with the PR objectives and code changes.

src/cli/translate.ts (1)

170-170: LGTM! Reasonable adjustment to translation output variability.

Increasing the temperature from 0 to 0.1 allows for slightly more varied translation outputs while remaining conservative. This should improve translation quality without significantly affecting consistency.

Note: This change is unrelated to the main boolean parsing fix but is a reasonable enhancement.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Signed-off-by: JounQin <admin@1stg.me>

Copilot

Pull Request Overview

This PR updates CLI flag parsing and translation settings to support releases on a 0.x branch by refining boolean handling and adjusting model temperature.

Increase default temperature for the translation command to 0.1
Revise --edit-repo option parser to treat no-value as true
Update parseBoolean helper to accept undefined as true

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/cli/translate.ts	Bump `temperature` from 0 to 0.1 for GPT model calls
src/cli/index.ts	Refine `--edit-repo` option coercion for no-value use
src/cli/helpers.ts	Adjust `parseBoolean` signature to allow `undefined`

Comments suppressed due to low confidence (1)

src/cli/helpers.ts:10

There may not be existing tests for the new parseBoolean(undefined) path. Please add unit tests covering cases for undefined, truthy, and falsy values to prevent regressions.

export const parseBoolean = (value?: string) =>

src/cli/index.ts

src/cli/helpers.ts

pkg-pr-new · 2025-05-29T13:30:43Z

Open in StackBlitz

npm i https://pkg.pr.new/@alauda/doom@36

commit: b4b7d81

JounQin · 2025-05-29T13:36:27Z

@coderabbitai full review

coderabbitai · 2025-05-29T13:36:32Z

✅ Actions performed

Full review triggered.

fix: boolean value parsing

8429019

JounQin requested a review from Copilot May 29, 2025 13:28

JounQin self-assigned this May 29, 2025

JounQin added the bug Something isn't working label May 29, 2025

JounQin changed the title ~~chore: allow release on 0.x branch~~ fix: boolean value parsing May 29, 2025

Create modern-knives-care.md

b4b7d81

Signed-off-by: JounQin <admin@1stg.me>

Copilot AI reviewed May 29, 2025

View reviewed changes

src/cli/index.ts Show resolved Hide resolved

src/cli/helpers.ts Show resolved Hide resolved

JounQin merged commit e51390c into 0.x May 29, 2025
16 of 17 checks passed

JounQin deleted the fix/parse_boolean branch May 29, 2025 13:41

github-actions bot mentioned this pull request May 29, 2025

chore: release @alauda/doom #37

Merged

This was referenced Jun 4, 2025

feat: support algolia alauda preset #51

Merged

fix: check when expression correctly #71

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: boolean value parsing #36

fix: boolean value parsing #36

Uh oh!

JounQin commented May 29, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented May 29, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented May 29, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new bot commented May 29, 2025 •

edited

Loading

Uh oh!

JounQin commented May 29, 2025

Uh oh!

coderabbitai bot commented May 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: boolean value parsing #36

fix: boolean value parsing #36

Uh oh!

Conversation

JounQin commented May 29, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JounQin commented May 29, 2025

Uh oh!

coderabbitai bot commented May 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JounQin commented May 29, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented May 29, 2025 •

edited

Loading

coderabbitai bot commented May 29, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

pkg-pr-new bot commented May 29, 2025 •

edited

Loading