-
Notifications
You must be signed in to change notification settings - Fork 2
fix: rspress built-in container directives #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: eaf0683 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughA constant set of container directive types was added to the code. The visitor function now returns early for nodes matching these types or with a specific class prefix, skipping further processing for these directives. No changes were made to exported or public entity signatures. Changes
Estimated code review effort2 (~15 minutes) Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes container directive handling by preventing certain container types from being processed by the general directive switch statement. The change ensures that standard container directive types (tip, note, warning, etc.) and rspress-directive containers are handled by their default behavior rather than falling through to custom processing logic.
- Adds a constant set of standard container directive types that should be excluded from custom processing
- Implements an early return condition to skip processing for these container types and rspress-directive containers
commit: |
Signed-off-by: JounQin <admin@1stg.me>
Summary by CodeRabbit