Fix crash on class fields that don't end in a semicolon #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #235 The previous code always ate the next token after a class field, which was a semicolon in all test cases so far. However, if the class field didn't end in a semicolon, it would eat the first token of the next class body member, which would confuse all downstream code and lead to errors. This means we end up leaving semicolons around in class bodies where class fields were, but this shouldn't cause problems, and it seems best to keep the transforms simple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235
The previous code always ate the next token after a class field, which was a
semicolon in all test cases so far. However, if the class field didn't end in a
semicolon, it would eat the first token of the next class body member, which
would confuse all downstream code and lead to errors.
This means we end up leaving semicolons around in class bodies where class
fields were, but this shouldn't cause problems, and it seems best to keep the
transforms simple.