fix: fix deprecated hass.components use #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace hass.components.persistent_notification.async_dismiss with async_diismiss_persistent_notification
|
Does this require a min HA bump? |
That is a good question... |
No. homeassistant 2024.2.0b0 components.persistent_notification contains So why was this question not raised on PR #2400 for the same changes in |
|
Sometimes I forget. |
alandtse
changed the title
alandtse
added a commit
that referenced
this pull request
Aug 20, 2024
fix: fix deprecated hass.components use (#2468)
|
Oh also, if you're talking about what was reverted in #2396. You also just merged without waiting for approval. That's a bit hard for me to ask the question when you don't wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace hass.components.persistent_notification.async_dismiss with async_diismiss_persistent_notification
addresses deprecated warning in issue in #2467