Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook - CIRC23 Variational data assimilation with deep prior #212

Merged
merged 11 commits into from
Sep 19, 2023

Conversation

acocac
Copy link
Member

@acocac acocac commented Sep 13, 2023

Summary

Postprint version from a notebook submission of the Climate Informatics Reproducibility Challenge (Fixes #178 )

List of changes proposed in this PR (pull-request)

Before review:

  • Add submodule from the notebook repo
  • Add new submodule path to _toc.yml
  • Add card of the new notebook
  • Add references
  • Hide code cell content of some sections e.g. Libraries, Tables, Last tested
  • Right-panel looks ok (headings)

Once reviewed/approved:

  • Replace binder url, postprint to main
  • Replace submodule branch, preview to render
  • Generate and add badges of DOI in the notebook file and gallery
  • Add authors/reviewers via all-contributors

What should a reviewer concentrate their feedback on?

Authors

Maintainers

  • Check badges in the gallery and notebook file
  • Check binder

Acknowledging contributors

Authors

  • Mukulikaa
  • Rutika-16

Reviewers

  • tinaok
  • crlna16
  • polpel

@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for the-environmental-ds-book ready!

Name Link
🔨 Latest commit bebe294
🔍 Latest deploy log https://app.netlify.com/sites/the-environmental-ds-book/deploys/6501a171c2333b00084f1daa
😎 Deploy Preview https://deploy-preview-212--the-environmental-ds-book.netlify.app/notebooks/gallery/39d9c177-11da-41b2-9b64-63f4c1c834b3/notebook
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@acocac acocac marked this pull request as draft September 13, 2023 08:37
@acocac
Copy link
Member Author

acocac commented Sep 13, 2023

👋 Hi @Mukulikaa @Rutika-16

This PR aims to provide a preview of the post-print version of your notebook submission. Feel free to explore it by clicking on the binder badge. We also appreciate if any of you complete the reviewers checklist (authors section) in the PR description.

The proposed version has some changes that facilitate running the notebook in the standard (free) and EGI replay binder instances. We've added pooch to fetch the output files from the run assimilations step. We also converted notebook the cell of this step to markdown. There is a yellow coloured box indicating this step would benefit from GPU's processing power.

Additional suggestions would be welcome. If everything looks ok, we aim to publish the notebook between Monday 18th and Tuesday 19th September 🗓️.

@acocac acocac marked this pull request as ready for review September 13, 2023 11:58
@acocac acocac added notebook Add/update notebook needs-review labels Sep 13, 2023
@acocac
Copy link
Member Author

acocac commented Sep 18, 2023

@all-contributors please add @Mukulikaa for blog, code

@allcontributors
Copy link
Contributor

@acocac

I've put up a pull request to add @Mukulikaa! 🎉

@acocac
Copy link
Member Author

acocac commented Sep 18, 2023

@all-contributors please add @Rutika-16 for blog, code

@allcontributors
Copy link
Contributor

@acocac

I've put up a pull request to add @Rutika-16! 🎉

@acocac
Copy link
Member Author

acocac commented Sep 18, 2023

@all-contributors please add @tinaok for review

@allcontributors
Copy link
Contributor

@acocac

I've put up a pull request to add @tinaok! 🎉

@acocac
Copy link
Member Author

acocac commented Sep 18, 2023

@all-contributors please add @crlna16 for review

@allcontributors
Copy link
Contributor

@acocac

I've put up a pull request to add @crlna16! 🎉

@acocac
Copy link
Member Author

acocac commented Sep 18, 2023

@all-contributors please add @polpel for review

@allcontributors
Copy link
Contributor

@acocac

I've put up a pull request to add @polpel! 🎉

@acocac
Copy link
Member Author

acocac commented Sep 18, 2023

@annefou can you please complete the checklist for maintainers and approve the PR if everything looks right? If everything is right, we'll announce the publication tomorrow Tuesday 19th Sept. Thank you 🙏

@acocac acocac requested a review from annefou September 18, 2023 14:31
Copy link
Collaborator

@annefou annefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice notebook!

I checked it with EGI Binder too. Very nice! Thank you.

@acocac acocac merged commit 6ef7d4b into master Sep 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook Add/update notebook published
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REVIEW] Variational data assimilation with deep prior
2 participants