Replace supports_bounded_execution with supports_retract_batch #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Jun 15, 2023
Owner
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
This looks really nice 👌 Thank you @mustafasrepo
Owner
|
I would like to propose we merge apache#6671 and then apply this change as its own PR as I think they are independent. |
…window functions (apache#6671) * feat: support sliding window accumulators Rationale: The default implementation of the `Accumulator` trait returns an error for the `retract_batch` API. * Allow AggregateUDF to define retractable batch * Return error rather than wrong results when aggregate without retract_batch is used as a sliding accumulator --------- Co-authored-by: Stuart Carnie <stuart.carnie@gmail.com>
# Conflicts: # datafusion/core/src/physical_plan/udaf.rs # datafusion/core/src/physical_plan/windows/mod.rs # datafusion/core/tests/user_defined_aggregates.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
With the changes in the target PR,
supports_retract_batchmethod is introduced to theAccumulatortrait. With the introduction ofsupports_retract_batchmethod,supports_bounded_executionmethod is no longer necessary for theAggregateExprtrait. (Similar to the case we have movesupports_bounded_executiontrait fromBuiltinWindowFunctionExprtoPartitionEvalautortrait.)This PR removes
supports_bounded_executionmethod fromAggregateExprand moves its functionality tosupports_retract_batchmethod in the Accumulator` trait for existing accumulators.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?