Conversation
alamb
pushed a commit
that referenced
this pull request
Aug 6, 2024
separate tests that require arrow into a separate module
alamb
pushed a commit
that referenced
this pull request
Nov 25, 2024
* Implement bulk_delete_request for Azure * Fix lint and add Azurite bug workaround * Special 404 error case * Clippy fix * Make number of expected headers more conservative and better document invariants * Use multer for multipart parsing * Fix clippy * Fix clippy #2 * Reuse part response buffer * Make multer conditional to azure feature * One more HeaderValue::from_static * Add tests for bulk delete request building and response parsing * Switch back to manual parsing to avoid multer dependency, other PR suggestions * Fixes lint
alamb
pushed a commit
that referenced
this pull request
Mar 20, 2025
* Implement bulk_delete_request for Azure * Fix lint and add Azurite bug workaround * Special 404 error case * Clippy fix * Make number of expected headers more conservative and better document invariants * Use multer for multipart parsing * Fix clippy * Fix clippy #2 * Reuse part response buffer * Make multer conditional to azure feature * One more HeaderValue::from_static * Add tests for bulk delete request building and response parsing * Switch back to manual parsing to avoid multer dependency, other PR suggestions * Fixes lint
alamb
pushed a commit
that referenced
this pull request
Feb 2, 2026
# Which issue does this PR close? small optimization # Rationale for this change key insight is the byte clone is cheap just a ref count compare to vec clone is a alloc + memcopy. before ``` let mut result = Vec::new(); // alloc #1 result.extend_from_slice(prefix); result.extend_from_slice(suffix); let data = Bytes::from(result.clone()); // alloc #2 + memcpy item.set_from_bytes(data); self.previous_value = result; // keep Vec ``` after ``` let mut result = Vec::with_capacity(prefix_len + suffix.len()); // alloc #1 result.extend_from_slice(&self.previous_value[..prefix_len]); result.extend_from_slice(suffix); let data = Bytes::from(result); // no alloc, takes Vec buffer item.set_from_bytes(data.clone()); // cheap refcount bump self.previous_value = data; // move, no alloc ``` # What changes are included in this PR? previous_value type changed to Bytes preallocate result vec capacity. # Are these changes tested? the existing test should pass # Are there any user-facing changes? no
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(testing PR against alamb/arrow-rs)
Rationale:
Locate PRs that affect various parts of the codebase to make it easier to find PRs in need of review
Changes:
Notes
You can see this working on https://github.com/alamb/arrow-rs (TODO link)