Partial backport of pull request matplotlib#7845 from vollbier/specgr…

…am_overlap_err Fixed bug with default parameters NFFT and noverlap in specgram() Did not backport the warning.
alainlompo · Jan 17, 2017 · 160fb26 · 160fb26
1 parent 4fbaeab
commit 160fb26
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -7190,8 +7190,12 @@ def specgram(self, x, NFFT=None, Fs=None, Fc=None, detrend=None,
         if not self._hold:
             self.cla()
 
+        if NFFT is None:
+            NFFT = 256  # same default as in mlab.specgram()
         if Fc is None:
-            Fc = 0
+            Fc = 0  # same default as in mlab._spectral_helper()
+        if noverlap is None:
+            noverlap = 128  # same default as in mlab.specgram()
 
         if mode == 'complex':
             raise ValueError('Cannot plot a complex specgram')

diff --git a/lib/matplotlib/mlab.py b/lib/matplotlib/mlab.py
@@ -1275,7 +1275,9 @@ def specgram(x, NFFT=None, Fs=None, detrend=None, window=None,
 
     """
     if noverlap is None:
-        noverlap = 128
+        noverlap = 128  # default in _spectral_helper() is noverlap = 0
+    if NFFT is None:
+        NFFT = 256  # same default as in _spectral_helper()
 
     spec, freqs, t = _spectral_helper(x=x, y=None, NFFT=NFFT, Fs=Fs,
                                       detrend_func=detrend, window=window,