Fixes #1
Merged
Fixes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es by default in zarr
… to be written to zarr
…into dtree-zarrv3-2
…r's fill_value in assertion
TomNicholas
commented
Mar 19, 2025
| @@ -1047,7 +1047,7 @@ def store( | |||
| kwargs = {} | |||
| if _zarr_v3(): | |||
| # https://github.com/zarr-developers/zarr-python/pull/2113#issuecomment-2386718323 | |||
| kwargs["path"] = self.zarr_group.name.lstrip("/") | |||
There was a problem hiding this comment.
FYI @TomAugspurger @jhamman and I are 95% sure that this line was unnecessary and a bug. It was causing consolidated metadata to not be written at the store root each time, and now that we changed it, it fixed various buggy behaviour we were seeing.
relevant to zarr-developers/zarr-python#2113 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't work out how to get the permissions right so I've just opened this against your PR branch @aladinor. I plan to make some more changes tomorrow.