Fix bedgraph error due to NA handling in meth.diff export #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #331 Fix the error in `tests/testthat/test-17-bedgraph.r` due to NA handling in `meth.diff` export as log-transformed value. * **R/bedgraph.R** - Disallow transformation of `meth.diff` values in `bedgraph` function for `methylDiff` objects. - Add a check to ensure `log.transform` is `FALSE` when `col.name` is `meth.diff`. * **tests/testthat/test-17-bedgraph.r** - Update tests to ensure `log.transform` is not allowed for `meth.diff` values. - Add a test to check for error when `log.transform` is `TRUE` for `meth.diff`. - Add tests for `methylDiffDB` objects to ensure `log.transform` is not allowed for `meth.diff` values. * **R/methylDBFunctions.R** - Add a check to ensure `log.transform` is `FALSE` when `col.name` is `meth.diff`. - Disallow transformation of `meth.diff` values in `bedgraph` function for `methylDiffDB` objects. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/al2na/methylKit/issues/331?shareId=XXXX-XXXX-XXXX-XXXX).
alexg9010
force-pushed
the
alexg9010/fix-bedgraph-error
branch
from
f9a2ae4 to
ad6cdc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #331
Fix the error in
tests/testthat/test-17-bedgraph.rdue to NA handling inmeth.diffexport as log-transformed value.R/bedgraph.R
meth.diffvalues inbedgraphfunction formethylDiffobjects.log.transformisFALSEwhencol.nameismeth.diff.tests/testthat/test-17-bedgraph.r
log.transformis not allowed formeth.diffvalues.log.transformisTRUEformeth.diff.methylDiffDBobjects to ensurelog.transformis not allowed formeth.diffvalues.R/methylDBFunctions.R
log.transformisFALSEwhencol.nameismeth.diff.meth.diffvalues inbedgraphfunction formethylDiffDBobjects.For more details, open the Copilot Workspace session.