Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select, autocomplete): don't open overlay without options #2930

Merged
merged 10 commits into from
Nov 17, 2021

Conversation

katebatura
Copy link
Contributor

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Prevent opening overlay-container with options using nb-select or nb-autocomplete if there is no options provided.

@katebatura katebatura requested a review from yggg November 5, 2021 10:23
@katebatura katebatura self-assigned this Nov 5, 2021
@katebatura katebatura requested a review from yggg November 9, 2021 11:58
@katebatura katebatura force-pushed the fix/overlay-not_open_if_no_options branch from 8528776 to b77f5d2 Compare November 9, 2021 12:47
@yggg yggg added this to the 9.0.0 milestone Nov 12, 2021
@yggg yggg changed the title fix(select, autocomplete): prevent opening overlay if no options fix(select, autocomplete): don't open overlay without options Nov 16, 2021
yggg
yggg previously approved these changes Nov 16, 2021
To conform common naming for such methods
@yggg yggg merged commit fca5cd1 into akveo:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants