-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(select, autocomplete): don't open overlay without options #2930
Merged
yggg
merged 10 commits into
akveo:master
from
katebatura:fix/overlay-not_open_if_no_options
Nov 17, 2021
Merged
fix(select, autocomplete): don't open overlay without options #2930
yggg
merged 10 commits into
akveo:master
from
katebatura:fix/overlay-not_open_if_no_options
Nov 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yggg
suggested changes
Nov 8, 2021
src/framework/theme/components/autocomplete/autocomplete.directive.ts
Outdated
Show resolved
Hide resolved
src/framework/theme/components/autocomplete/autocomplete.directive.ts
Outdated
Show resolved
Hide resolved
yggg
suggested changes
Nov 8, 2021
katebatura
force-pushed
the
fix/overlay-not_open_if_no_options
branch
from
November 9, 2021 12:47
8528776
to
b77f5d2
Compare
yggg
changed the title
fix(select, autocomplete): prevent opening overlay if no options
fix(select, autocomplete): don't open overlay without options
Nov 16, 2021
yggg
previously approved these changes
Nov 16, 2021
To conform common naming for such methods
yggg
force-pushed
the
fix/overlay-not_open_if_no_options
branch
from
November 16, 2021 14:16
dbf9f6c
to
b1502ac
Compare
yggg
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Prevent opening overlay-container with options using
nb-select
ornb-autocomplete
if there is no options provided.