Skip to content

feat(date-time picker): ability to remove now button #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 8, 2021
Merged

feat(date-time picker): ability to remove now button #2848

merged 8 commits into from
Nov 8, 2021

Conversation

evtkhvch
Copy link
Contributor

@evtkhvch evtkhvch commented Aug 26, 2021 •
edited
Loading

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes: #2845

  • add showCurrentTimeButton property to NbDateTimePickerComponent
  • add showCurrentTimeButton property to NbCalendarWithTimeComponent
  • add showCurrentTimeButton property to NbCalendarActionsComponent

how to use:

<input nbInput placeholder="Pick Date" [nbDatepicker]="dateTimePicker">
<nb-date-timepicker
  [isCurrentTimeButton]="false"
  withSeconds
  #dateTimePicker>
</nb-date-timepicker>

result:

Screenshot 2021-08-26 at 12 21 38

@evtkhvch evtkhvch marked this pull request as ready for review August 26, 2021 09:18
@yggg yggg changed the title feat(datetime-picker): allow removing now button feat(datetime picker): allow removing now button Nov 8, 2021
@yggg yggg changed the title feat(datetime picker): allow removing now button feat(datetime picker): ability to remove now button Nov 8, 2021
@yggg yggg changed the title feat(datetime picker): ability to remove now button feat(date-time picker): ability to remove now button Nov 8, 2021
@yggg yggg merged commit a2c9d10 into akveo:master Nov 8, 2021
@bram2202 bram2202 mentioned this pull request Jul 13, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yggg yggg yggg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

I need to remove "now" button from NbDateTimePicker.

2 participants

@evtkhvch @yggg